[SDK] fix: Prevent popup when using auth redirect mode #6246

joaquim-verges · 2025-02-13T02:21:30Z

Fixes TOOL-3410

PR-Codex overview

This PR focuses on enhancing the authentication process in the thirdweb wallet, specifically by introducing async handling for login methods and adding a Google login option.

Detailed summary

Changed authenticateWithRedirect and loginWithOauthRedirect to return Promise<void>.
Added a 5-second delay in loginWithOauthRedirect before proceeding.
Introduced loginWithGoogle function for Google authentication.
Updated UI to include a "Login with Google" button.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2025-02-13T02:21:34Z

🦋 Changeset detected

Latest commit: 18e49ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/wagmi-adapter	Patch
thirdweb-login	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-02-13T02:21:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 13, 2025 2:52am
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 13, 2025 2:52am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 13, 2025 2:52am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 13, 2025 2:52am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 13, 2025 2:52am

joaquim-verges · 2025-02-13T02:21:49Z

[SDK] fix: Prevent popup when using auth redirect mode #6246 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

linear · 2025-02-13T02:21:56Z

TOOL-3410 Redirect option causing both pop-up and new window to open

github-actions · 2025-02-13T02:28:25Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	46.3 KB (0%)	926 ms (0%)	2.9 s (+26.79% 🔺)	3.8 s
thirdweb (cjs)	121.89 KB (0%)	2.5 s (0%)	5.1 s (-18.89% 🔽)	7.5 s
thirdweb (minimal + tree-shaking)	5.6 KB (0%)	112 ms (0%)	615 ms (+157.98% 🔺)	727 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	69 ms (+53.68% 🔺)	79 ms
thirdweb/react (minimal + tree-shaking)	19.29 KB (0%)	386 ms (0%)	481 ms (+0.61% 🔺)	867 ms

codecov · 2025-02-13T02:32:32Z

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.86%. Comparing base (880148b) to head (18e49ee).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../thirdweb/src/wallets/in-app/web/lib/auth/oauth.ts	0.00%	4 Missing ⚠️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts	33.33%	2 Missing ⚠️
...s/thirdweb/src/wallets/in-app/core/wallet/index.ts	0.00%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (12.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6246      +/-   ##
==========================================
- Coverage   56.87%   56.86%   -0.01%     
==========================================
  Files        1166     1166              
  Lines       64522    64523       +1     
  Branches     5223     5221       -2     
==========================================
- Hits        36699    36694       -5     
- Misses      27095    27101       +6     
  Partials      728      728

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 880148b
packages	`55.08% <12.50%> (-0.02%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...s/thirdweb/src/wallets/in-app/core/wallet/index.ts	`73.91% <0.00%> (ø)`
...irdweb/src/wallets/in-app/web/lib/web-connector.ts	`39.38% <33.33%> (ø)`
.../thirdweb/src/wallets/in-app/web/lib/auth/oauth.ts	`5.00% <0.00%> (-1.07%)`	⬇️

... and 2 files with indirect coverage changes

github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 13, 2025

github-actions bot assigned joaquim-verges Feb 13, 2025

joaquim-verges marked this pull request as ready for review February 13, 2025 02:21

joaquim-verges requested review from a team as code owners February 13, 2025 02:21

vercel bot had a problem deploying to Preview – thirdweb_playground February 13, 2025 02:24 Failure

vercel bot deployed to Preview – wallet-ui February 13, 2025 02:24 View deployment

vercel bot deployed to Preview – login February 13, 2025 02:24 View deployment

joaquim-verges force-pushed the _SDK_fix_Prevent_popup_when_using_auth_redirect_mode branch from 5a1f394 to b5563ca Compare February 13, 2025 02:24

vercel bot deployed to Preview – login February 13, 2025 02:25 View deployment

vercel bot deployed to Preview – wallet-ui February 13, 2025 02:25 View deployment

vercel bot had a problem deploying to Preview – thirdweb_playground February 13, 2025 02:26 Failure

vercel bot deployed to Preview – docs-v2 February 13, 2025 02:30 View deployment

vercel bot deployed to Preview – thirdweb-www February 13, 2025 02:30 View deployment

[SDK] fix: Prevent popup when using auth redirect mode

18e49ee

joaquim-verges force-pushed the _SDK_fix_Prevent_popup_when_using_auth_redirect_mode branch from b5563ca to 18e49ee Compare February 13, 2025 02:49

vercel bot deployed to Preview – wallet-ui February 13, 2025 02:50 View deployment

vercel bot deployed to Preview – login February 13, 2025 02:50 View deployment

vercel bot deployed to Preview – docs-v2 February 13, 2025 02:51 View deployment

vercel bot deployed to Preview – thirdweb_playground February 13, 2025 02:52 View deployment

vercel bot deployed to Preview – thirdweb-www February 13, 2025 02:52 View deployment

joaquim-verges merged commit 98b6198 into main Feb 13, 2025
33 of 34 checks passed

joaquim-verges deleted the _SDK_fix_Prevent_popup_when_using_auth_redirect_mode branch February 13, 2025 03:31

joaquim-verges mentioned this pull request Feb 13, 2025

Version Packages #6247

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] fix: Prevent popup when using auth redirect mode #6246

[SDK] fix: Prevent popup when using auth redirect mode #6246

Uh oh!

joaquim-verges commented Feb 13, 2025 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Feb 13, 2025 •

edited

Loading

Uh oh!

vercel bot commented Feb 13, 2025 •

edited

Loading

Uh oh!

joaquim-verges commented Feb 13, 2025

Uh oh!

linear bot commented Feb 13, 2025

Uh oh!

github-actions bot commented Feb 13, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[SDK] fix: Prevent popup when using auth redirect mode #6246

[SDK] fix: Prevent popup when using auth redirect mode #6246

Uh oh!

Conversation

joaquim-verges commented Feb 13, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquim-verges commented Feb 13, 2025

How to use the Graphite Merge Queue

Uh oh!

linear bot commented Feb 13, 2025

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaquim-verges commented Feb 13, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented Feb 13, 2025 •

edited

Loading

vercel bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

codecov bot commented Feb 13, 2025 •

edited

Loading